Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with undo in CellExternalCopyManager #917

Open
doornik opened this issue Nov 17, 2023 · 1 comment
Open

Problem with undo in CellExternalCopyManager #917

doornik opened this issue Nov 17, 2023 · 1 comment

Comments

@doornik
Copy link

doornik commented Nov 17, 2023

In /plugins/slick.cellexternalcopymanager.ts (308) the undo function should ignore oneCellToMultiple.

Instead all values should be restored. The problem can be verified in the Spreadsheet: features of the previous example plus Excel compatible copy and paste example:

  1. copy a single value
  2. select a range
  3. paste the single value, which is applied to all selected cells as expected
  4. Ctrl+Z to undo goes wrong

Unfortunately the clipCommand binds to the oneCellToMultiple value of the parent, not of itself, so a quick hack of setting it to false is not possible.

For the purpose of separating the data in a DataView, I would prefer it if setDataItemValueForColumn would use desty as the first argument in the call to dataItemColumnValueSetter, rather than content of the current row in item. The current approach does not make the row known.

Thanks for a great grid.

@ghiscoding
Copy link
Collaborator

ghiscoding commented Jan 22, 2024

@doornik Please contribute a Pull Request since you seem to have the knowledge on how to fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants