Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npm script to update Playwright e2e snapshots #9596

Open
shendy-a8c opened this issue Oct 20, 2024 · 1 comment · May be fixed by #9544
Open

Add npm script to update Playwright e2e snapshots #9596

shendy-a8c opened this issue Oct 20, 2024 · 1 comment · May be fixed by #9544

Comments

@shendy-a8c
Copy link
Contributor

There is already an npm script to update snapshot for unit tests: npm run test:update-snapshots.
However, I couldn't find one for Playwright e2e tests.

The readme mentions the command to update the snapshots but it will be nice an "symmetrical" to unit test's if it's available as npm script as well.
@shendy-a8c shendy-a8c linked a pull request Oct 20, 2024 that will close this issue
Open
6 tasks
@haszari
Copy link
Contributor

haszari commented Oct 21, 2024

There is already an npm script to update snapshot for unit tests: npm run test:update-snapshots.
However, I couldn't find one for Playwright e2e tests.

I have no objection to us adding more npm scripts.

However I'd lean the other way:

  • Keep the npm scripts to the bare minimum.
  • Lean on documentation to encourage deeper understanding of our toolchain.

If we have less scripts / aliases in our package.json it encourages everyone to learn the tooling directly. Scripts can act like a "buffer", a crutch on top of the tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

npm script to update e2e-pw screenshots / snapshots Automattic/woocommerce-payments
2 participants
@haszari @shendy-a8c