Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring: Update monitoring charts to get colors from color studio #95550

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

matt-west
Copy link
Contributor

@matt-west matt-west commented Oct 21, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/9474

Proposed Changes

  • Update the color used by the charts on the Monitoring page to use our latest color palette.
  • Pull colors from the color-studio package so they are kept in-sync with future color updates.
  • Uses the chroma package to automatically generate transparent colors, future-proofing against future changes to the color-studio package.

Left: Before | Right: After

Screenshot 2024-10-21 at 12 59 48

Why are these changes being made?

  • To ensure colors used on the Monitoring page match our brand palette.

Testing Instructions

  • Go to /site-monitoring/[domain]

@matt-west matt-west self-assigned this Oct 21, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 21, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/monitoring-chart-colors on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Oct 21, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14102 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
site-monitoring     +34428 B  (+2.4%)   +14102 B  (+3.4%)
site-logs           +34428 B  (+2.4%)   +14102 B  (+3.4%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matt-west matt-west marked this pull request as ready for review October 21, 2024 13:28
@matt-west matt-west requested a review from a team October 21, 2024 13:28
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants