Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When removing URL filter, column dropdown boxes don't reflect change #111

Open
EitanBlumin opened this issue Apr 7, 2019 · 2 comments
Open
Assignees
Labels
bug Something isn't working or isn't right help wanted Extra attention is needed

Comments

@EitanBlumin
Copy link
Owner

After removing a filter set by a URL parameter, the items filled in the dropdown box of column filters is not set to reflect all available values in the table.

@EitanBlumin EitanBlumin added the bug Something isn't working or isn't right label Apr 7, 2019
@EitanBlumin EitanBlumin added this to the Alpha release 1 milestone Apr 7, 2019
@EitanBlumin EitanBlumin self-assigned this Apr 7, 2019
@EitanBlumin
Copy link
Owner Author

May need to re-render column filters on every draw event.
On the other hand, this may still not be good enough because I think the data would only be retrieved from current page and this may cause lost values.

Other than reverting to displaying all Dropdown values, I'm not sure what else to do.
Maybe use datatable values only when there's only one page to display? But then we would lose values when other filters are used.

Damnit I don't know what to do. Bah.

@EitanBlumin
Copy link
Owner Author

The solution offered in #115 could be useful to solve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or isn't right help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant