Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot emulate gbtidl's edge smoothing #275

Closed
teuben opened this issue Jun 22, 2024 · 2 comments
Closed

cannot emulate gbtidl's edge smoothing #275

teuben opened this issue Jun 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@teuben
Copy link
Collaborator

teuben commented Jun 22, 2024

Describe the bug
The default smoothing near the edge of a spectrum uses /edge_truncate ig gbtidl, which is the same as boundary="extend", but specutils smoothing has no API to use **kwargs to override the boundary='fill' default.
Until specutils has this API change (requested), we cannot exactly reproduce GBTIDL smoothing. For good measure the test should pick some central portion of the spectrum.

How to Reproduce

Environment

  • Dysh version
  • Python version
  • OS
@teuben teuben added the bug Something isn't working label Jun 22, 2024
@teuben
Copy link
Collaborator Author

teuben commented Jun 24, 2024

I've submitted a discussion issue on specutils astropy/specutils#1147

@teuben
Copy link
Collaborator Author

teuben commented Jun 25, 2024

Since I switched to core.smooth where astropy's convolution is used, this issues is less of an issue for us. I'm thus closing it for now,but keep the one in specutils open.

@teuben teuben closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant