Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit interface design and performance in IntersectionShaper #1445

Open
6 tasks
gunney1 opened this issue Oct 11, 2024 · 0 comments
Open
6 tasks

Revisit interface design and performance in IntersectionShaper #1445

gunney1 opened this issue Oct 11, 2024 · 0 comments
Assignees
Labels
Klee Related to the Klee component Performance Issues related to code performance Quest Issues related to Axom's 'quest' component Reviewed

Comments

@gunney1
Copy link
Contributor

gunney1 commented Oct 11, 2024

The work in #1436 and [Blueprint mesh support for shaping, MR TBD] were done under some time pressure from an application. Some of the interface and potential performance issues should be discussed, examined and fixed if needed. This issue is here to collect things that came up regarding that work.

  • Check whether specifying klee::Geometry format by string a problem for performance. Fix if needed.
  • There are some code whose presence crashes weirdly in Docker. Running in Docker is not a requirement of the driving application, so the offending code is disabled. Find and fix the root cause.
  • The method klee::Geometry::hasGeometry method may cause confusion. What does it mean for a Geometry to have or not have a "geometry"? The method actually meant whether Geometry is read in from disk. Now that Geometry can also be constructed in memory it can have a geometry even if not read in from disk.
  • The code uses both host and device memory. We should ensure that we're not unnecessarily moving data between host and device.
  • Move the DiscreteShape into an internal namespace, as noted by the comment in its documentation. The class isn't meant for public use and may change upon the interface revisit.
  • Consider subclassing Geometry to represent the multitude of geometry specification that are currently done by multiple constructors.
@gunney1 gunney1 added Quest Issues related to Axom's 'quest' component Klee Related to the Klee component Performance Issues related to code performance labels Oct 11, 2024
@gunney1 gunney1 self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Klee Related to the Klee component Performance Issues related to code performance Quest Issues related to Axom's 'quest' component Reviewed
Projects
None yet
Development

No branches or pull requests

2 participants