Revisit interface design and performance in IntersectionShaper
#1445
Labels
Klee
Related to the Klee component
Performance
Issues related to code performance
Quest
Issues related to Axom's 'quest' component
Reviewed
The work in #1436 and [Blueprint mesh support for shaping, MR TBD] were done under some time pressure from an application. Some of the interface and potential performance issues should be discussed, examined and fixed if needed. This issue is here to collect things that came up regarding that work.
klee::Geometry
format by string a problem for performance. Fix if needed.klee::Geometry::hasGeometry
method may cause confusion. What does it mean for aGeometry
to have or not have a "geometry"? The method actually meant whetherGeometry
is read in from disk. Now thatGeometry
can also be constructed in memory it can have a geometry even if not read in from disk.DiscreteShape
into an internal namespace, as noted by the comment in its documentation. The class isn't meant for public use and may change upon the interface revisit.Geometry
to represent the multitude of geometry specification that are currently done by multiple constructors.The text was updated successfully, but these errors were encountered: