use Makie 0.21 #12
use Makie 0.21 #12
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 29.78% 29.60% -0.19%
==========================================
Files 5 5
Lines 413 402 -11
==========================================
- Hits 123 119 -4
+ Misses 290 283 -7 ☔ View full report in Codecov by Sentry. |
| version = "0.2.1" | ||
| version = "0.2.2" |
There was a problem hiding this comment.
Should this be breaking? It will cause a lot of workflows using eg CanvasSelect to fail...
| version = "0.2.1" | |
| version = "0.2.2" | |
| version = "0.3.0" |
There was a problem hiding this comment.
Yeah I bumped the version before I broke everything
| @@ -425,7 +427,7 @@ function add_events!(c::GeometryCanvas{<:Point}; | |||
|
|
|||
|
|
|||
| # Mouse down event | |||
| on(events(ax.scene).mousebutton, priority=100) do event | |||
| on(events(ax.scene).mousebutton, priority=-100) do event | |||
There was a problem hiding this comment.
Does this fix the issue you posted about?
There was a problem hiding this comment.
It might create other issues though... like you wont be able to draw over Tyler.jl maps
There was a problem hiding this comment.
I was hoping that popups were somehow separate from this system - because they are style as being above any other layer
There was a problem hiding this comment.
If it's just a plot then no...and it looks like you are using Consume(true) in places as well so it shouldn't be an issue there. Why would Tyler be a problem here?
There was a problem hiding this comment.
Like shouldn't popups have a priority of typemax(Int) ? @SimonDanisch how does this work exactly?
How can MakieDraw layers be always above the other layers but below Menu popups in click event order
There was a problem hiding this comment.
Menu has a priority of 65 ^^ so I guess it needs to below that? And all others should have 1 as a default...
Anything unimportant is negative and system stuff should have something like max int, I think.
Definitely needs some better docs
There was a problem hiding this comment.
Oh good maybe MakieDraw can be 50 then rather than 100
Co-authored-by: Anshul Singhvi <[email protected]>
No description provided.