Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix compatibility for Makie v0.21+ and AlgebraOfGraphics v0.7+ #23

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

yhqjohn
Copy link
Contributor

@yhqjohn yhqjohn commented Sep 12, 2024

  • pass the screen config related arguments in the keyword form rather than a ScreenConfig struct to make it compatible with the different defintion of ScreenConfig in CairoMakie v0.20- and v0.21+
  • add AlgebraOfGraphicsExt module to make it compatible with AoG v0.7+ which requires implementing aesthetic mapping for all plots. This is based on the weakdeps feature of Julia 1.9+.

@asinghvi17
Copy link
Member

Thanks for the PR! Will get a new release out shortly.

@asinghvi17 asinghvi17 merged commit 27f4442 into MakieOrg:main Sep 12, 2024
3 of 4 checks passed
@asinghvi17 asinghvi17 mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants