dnsdist: Add meson support #14724
Draft
dnsdist: Add meson support #14724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11405281222Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
I tested macOS (dnsdist + testrunner, no further options), no changes needed. This patch makes basic build of dnsdist + testrunner succeed on OpenBSD: |
|
Applied, thanks! |
rgacogne
force-pushed
the
meson
branch
3 times, most recently
from
2fc3876
to
7a57f5e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -29,19 +29,19 @@ | |||
| #include "dnsparser.hh" | |||
|
|
|||
| // NOLINTNEXTLINE(readability-function-cognitive-complexity): this function declares Lua bindings, even with a good refactoring it will likely blow up the threshold | |||
| void setupLuaBindingsDNSQuestion(LuaContext& luaCtx) | |||
| void setupLuaBindingsDNSQuestion([[maybe_unused]] LuaContext& luaCtx) | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
The `#if` should be `#ifdef` or `#if defined`, as otherwise it fails with the `config.h` generated by `meson`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR is unfortunately duplicating quite a lot of sub-directories from the root
mesondirectory used by the auth and rec, because we are either using them in a different way or the description is not accurate for dnsdist. It might make sense to use symlinks for the directories we are not modifying?Closes #14654
Checklist
I have: