Upgrade Go & dependencies, drop unsupported Go versions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahouene
commented
Oct 14, 2024
•
ahouene
commented
- upgrade Go to go1.22.8
- drop support for go1.18 and go1.19
- upgrade Go dependencies
- upgrade GitHub Actions
- upgrade golangci-lint
This was
linked to
issues
Oct 14, 2024
Closed
johanlantz
reviewed
Oct 16, 2024
| @@ -1,45 +1,40 @@ | |||
| module github.com/PowerDNS/simpleblob | |||
|
|
|||
| go 1.18 | |||
| go 1.22 | |||
There was a problem hiding this comment.
Any reason to not use 1.23.2 here?
Debugging in MacOS is broken in 1.22 if the user updates to Sequoia, this is fixed in 1.23.
There was a problem hiding this comment.
This directive specifies the minimum version and won't prevent you from using 1.23. See https://go.dev/doc/modules/gomod-ref#go
Though, I updated the toolchain directive to explicitely use go1.23.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.