Support Postgres Interval, Range, Bit, and BitVarying

[alex-tan]

Motivation

Adds support for this column type.

Implementation

I followed the other implementations of the postgres column types.

Tests

No tests since there's not an established way of doing that in the repo for this type of feature.

[amomchilov]

Thanks!

Are there any other PG column types that we should add here?

[alex-tan]

👍

I took a cursory look based on this and found that these were T.untyped in the rbis:

Postgres Type	Rails Type
bit	String
bit varying	String
point	ActiveRecord::Point

I can add them to this PR.

I didn't dig far enough to see if these would work already or not: hstore, legacy_point, vector

[alex-tan]

I tested these three new columns however ActiveRecord::Point doesn't resolve after the rbis are generated. Is there a place I should add a shim for that?

[amomchilov]

@alex-tan It seems to fall under this category, so perhaps you can just declare it in activerecord_postgresql.rbi as well?

tapioca/sorbet/rbi/shims/activerecord_postgresql.rbi

Line 3 in 28b06aa

# These constants are dynamically loaded only when connecting to postgresql

class Point < Struct.new(:x, :y)
   sig { returns(FloatButImNotSure) } # TODO: Fill in correct types
   def x; end
   
   sig { params(x:FloatButImNotSure).returns(FloatButImNotSure) }
   def x=(x); end
   
   sig { returns(FloatButImNotSure) }
   def y; end

   sig { params(x:FloatButImNotSure).returns(FloatButImNotSure) }
   def y=(x); end
end

[alex-tan]

But that file doesn't end up in the shims for the project using tapioca right?

[amomchilov]

Ahh, you're right, these are just shims for Tapioca's own internal use.

Hmmm... I'll ask for guidance internally. To get you unblocked quicker, would you like to roll this PR back to just the original support for Interval? I'll approve/merge that right away, then you can split the rest in their own new PR

[alex-tan]

Sounds good, thanks 👍

[alex-tan]

I went back and added Bit/BitVarying support again and also support for Range. It looks like there's a PR out to fix CI so I'll rebase when that gets merged.

[egiurleo]

Hi, @alextan! We just fixed CI on Ruby 3.3.5. Would you mind rebasing on main and force pushing your branch?

[alex-tan]

@egiurleo sure thing, done 👍