Correct type annotation in ActiveRecordColumnTypeHelper's
#2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
amomchilov
approved these changes
Sep 7, 2024
amomchilov
changed the title
ActiveRecordColumnTypeHelper's
|
Hey @cquinones100, we're investigating some flakey Ruby 3.4 issues in our CI pipeline. We'll merge this PR as soon as it's sorted out :) |
Thanks for letting me know! |
ActiveRecordColumnTypeHelper's @constant.primary_key can be nil for models that don't have a primary key
egiurleo
force-pushed
the
issue-1997-correct-custom_type_for-annotation
branch
from
4bd2cc1
to
6b93d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveRecordColumnTypeHelper's
@constant.primary_keycan benilfor models that don't have a primary key.Motivation
Closes #1997
Tests
This is a change to the type annotation, so not test is necessary.