Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use consistent colors and symbology for all TADA maps? #465

Open
6 tasks
cristinamullin opened this issue May 24, 2024 · 1 comment
Open
6 tasks
Labels
Future Improvement Minimum viable function complete, issue includes potential future improvements Module 2

Comments

@cristinamullin
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Should the colors and symbology used for TADA maps be consistent?

TADA_ColorPalette()
TADA_ViewColorPalette()

The TADA color palette is color blind friendly. Hopefully, it is also already 508 compliant. @erg-hzhou offered to check this for us. Once the colors are finalized, we will use this palette for all new TADA figs and maps.

In addition, let's review the symbology used within TADA maps.
TADA_OverviewMap()
TADA_ViewATTAINS()

@renaemyers is also working on a new site review map function: #464 so this issue is relevant to the colors and symbols we decide to use there...

Here are other options for map symbols: https://designsystem.digital.gov/components/icon/

Describe the solution you'd like

Ensure colors are 508 compliant. Colors and symbols can be consistent across maps/figures where possible (but not always necessary).

Describe alternatives you've considered

Some maps/figs may require more specific colors or symbols thus consistency is not as important and making sure they look good and are user friendly.

Reminders for TADA contributors addressing this issue

New features should include all of the following work:

  • Create the function/code.

  • Document all code using comments to describe what is does.

  • Create tests in tests folder.

  • Create help file using roxygen2 above code.

  • Create working examples in help file (via roxygen2).

  • Add to appropriate vignette (or create new one).

@erg-hzhou
Copy link
Collaborator

Regarding the color contrast for 580 compliance, I verified the the 2 URL links. Most of those elements are fine with 508 compliance checker - ANDI. However, we may need to be careful to use the closest colors in the charts or maps. We want to make sure we have enough contrast ratio. I recommend development team to add this link to your Chrome or Edge browser to check it as you go - https://www.ssa.gov/accessibility/andi/help/modules.html#cANDI

@hillarymarler hillarymarler added Future Improvement Minimum viable function complete, issue includes potential future improvements Module 2 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Future Improvement Minimum viable function complete, issue includes potential future improvements Module 2
Projects
None yet
Development

No branches or pull requests

4 participants