Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option to change the tray icon used by Vesktop #571

Closed
Tiagoquix opened this issue May 3, 2024 · 17 comments · May be fixed by #576
Closed

Add a new option to change the tray icon used by Vesktop #571

Tiagoquix opened this issue May 3, 2024 · 17 comments · May be fixed by #576
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Tiagoquix
Copy link
Contributor

Tiagoquix commented May 3, 2024

Hi there. I would like to have a command-line flag or GUI option to change the icon used by Vesktop on the system tray. For the GUI, it could be something together with the "Tray Icon" option in "Vesktop Setttings".

My reasoning for this request is because I personally prefer to use original Discord icons.
To clarify, I'm not requesting to add Discord icons inside Vesktop itself. What I'm requesting is to let the user choose custom icons from their PC directly.

For the app itself, I can do it using the .desktop file on my DE (KDE Plasma), but I can't modify the VC icon due to it being hardcoded in Vesktop itself. (I could, but I would have to recompile the program, and that's not very convenient when updating.)

Context of this issue: see issues #448 and #570.

One thing that I'm not sure is about having static.ico and static.png. If I could modify Vesktop's tray icon, which extension would I have to use? Or would I need to have both file extensions for two copies of the same image? I think it would be interesting to use only .ico or .png to make it simpler (if needed).

Thanks in advance to all contributors, and a special thanks to Vendicated for having a very friendly behavior.

image

@Tiagoquix Tiagoquix added the enhancement New feature or request label May 3, 2024
@Vendicated
Copy link
Member

Vendicated commented May 3, 2024

adding this feature would be fairly trivial, one would just need to get the user preference, check if the specified path exists, and then adjust the path passed here

tray = new Tray(ICON_PATH);

@Vendicated Vendicated added the good first issue Good for newcomers label May 3, 2024
@MrGarlic1
Copy link
Contributor

I plan on working on this tomorrow with a GUI file select option in vesktop settings. Just need to familiarize myself with the project first :)

@scoliono
Copy link

scoliono commented May 5, 2024

#505 and #506 are worth mentioning too, for a third party client which is all about customization it's ironic that the devs shut down any discussion about changing the assets.

@Cynosphere
Copy link
Contributor

it's ironic that the devs shut down any discussion about changing the assets.

Both issues were either started as or ended with harassment which is why. The time spent wasted arguing, someone could've just made a PR for it already.

@Tiagoquix
Copy link
Contributor Author

#505 and #506 are worth mentioning too, for a third party client which is all about customization it's ironic that the devs shut down any discussion about changing the assets.

On Windows, you can right-click and change the icon, and I believe that applies to the task bar as well.

On Linux, depending on your desktop environment, you can edit /usr/share/applications/vesktop.desktop (at least on KDE Plasma) and change the Icon line to point to an icon name from your icon pack, or to point to a PNG or ICO file directly.

On MacOS, I have no idea.

@scoliono
Copy link

scoliono commented May 5, 2024

It seems to me like both issues were started in good faith. No one has addressed why 506 was immediately closed.

@AAGaming00
Copy link
Contributor

It seems to me like both issues were started in good faith. No one has addressed why 506 was immediately closed.

did anybody ask

@Cynosphere
Copy link
Contributor

On Windows, you can right-click and change the icon, and I believe that applies to the task bar as well.

This is misleading. This only changes the shortcut's icon in the taskbar and does not reflect changes in the system tray (the point of this issue) and a multitude of other places, especially if the app has a dynamic icon for notifications or such.

@Tiagoquix
Copy link
Contributor Author

Sorry then. I don't use Windows anymore, so I can't help with that.

I would suggest you to use official Discord app with Vencord and OpenAsar applied, which should fix the issue.

@padgriffin
Copy link

On Linux, depending on your desktop environment, you can edit /usr/share/applications/vesktop.desktop (at least on KDE Plasma) and change the Icon line to point to an icon name from your icon pack, or to point to a PNG or ICO file directly.

If you're using the Flatpak version, you can find it at /.local/share/applications/dev.vencord.Vesktop.desktop.

I hate that I have to do this but I am LGBTQ myself, I just prefer the original Discord logo over the VC in my dock. If someone could point me to a pride ico file for the original logo it would be much appreciated. I tried using ones meant for MacOS but they were too small for some reason.

@ProjWyrd
Copy link

On Windows, you can right-click and change the icon, and I believe that applies to the task bar as well.

(Bit of context, I'm the original poster of #505 )

I'm not quite sure what you mean here. Do you mean to right click on the shortcut? If so I think this would work but I personally prefered using the portable version of vesktop and just running the exe. Having an icon changed baked into vesktop would make it easier for all users to change the icon on any platform

@Axenide
Copy link

Axenide commented May 23, 2024

I'd like to have this feature. Maybe having the option to change it to something similar to the Discord icon (like Webcord does), but also having the option to upload a custom one.

@satk0
Copy link

satk0 commented May 24, 2024

Instead of having too much customization, I would go with a simple: Turn off cuteness option that changes the icon and the loading gif to a rigid alternative.

@ThatOverPowered
Copy link

As temp workaround, is possible to setup a custom icon using the gnome-shell-extension-appindicator extension.
imagen

@Commenter25
Copy link

The above workaround will break if you have any other Electron-based app placing a tray icon, such as Signal. All of them will have the same icon. Perhaps if there's a way to make it report a unique ID, this would help as a stopgap solution.

@Tiagoquix
Copy link
Contributor Author

For KDE people, see #576 (comment) on how to change the icon used in alt+tab and other places (doesn't affect tray icon).

@Covkie Covkie mentioned this issue Jun 18, 2024
13 tasks
@Vendicated
Copy link
Member

closing in favour of #667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.