-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
title / artist fail if winamp scrolling title feature is enabled #4
Comments
Sample test run:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I just wanted to report a bug in that WinampRPC currently fails to get the track/title information correctly if you have the winamp option on that scrolls the title.
I'm not comfortable with submitting pull requests, I'm a bit old school in that I'd rather manually describe the fix.
I ended up having to write a function which i put in winamp.py (but not in the class definition) that unbreaks this, and wanted to share it with you.
However, my solution is incomplete because it only works if you change Winamp's advanced title formatting to separate the artist and title with an endash (–) instead of a hyphen (-). I did this because bands and songs can both have hyphens in them, and I didn't want to figure out the splitting code, sorry.
Then,
get_track_title
was modified to use this new function:And get_trackinfo_raw was introduced as a way to access the buggy title (i.e., the titles you fetch now in their unprocessed state):
I collected all the titles for a particular song and created some test data to test my function out:
Once I got that working, I ran it on winamp and advanced tracks many times, and it got the artist and title correct 100% of the time.
The text was updated successfully, but these errors were encountered: