Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop external gas recommendation #34

Open
sakulstra opened this issue Oct 7, 2021 · 0 comments
Open

drop external gas recommendation #34

sakulstra opened this issue Oct 7, 2021 · 0 comments
Labels
question Further information is requested

Comments

@sakulstra
Copy link
Contributor

sakulstra commented Oct 7, 2021

The aave app currently uses an external service for gas estimation.
In #33 I replaces gasnow with paraswap gas api, but while doing this I started wondering if we really need this.

Most interactions on the aave protocol don't need to happen fast.
Except for liquidations and swaps most transactions don't rely on timing - therefore I think i should be possible to completely drop the recommendation & instead go with the wallets getGasPrice/ rely on people speeding things up there.

Need to do some benchmarking on getGasPrice troughout supported wallets though.

@sakulstra sakulstra added the question Further information is requested label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant