Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit matic in the history shows change of usage as collateral instead of deposit #92

Open
foodaka opened this issue Oct 27, 2021 · 3 comments

Comments

@foodaka
Copy link
Contributor

foodaka commented Oct 27, 2021

Background:
When a user deposits matic into the pool, it should show up in their history. This currently happens however, it is shown as a change of usage as collateral. I feel this is a bit confusing for the user because they did a deposit but it shows up as usage as collateral

Screen Shot 2021-10-27 at 11 59 29 AM

@foodaka foodaka added design required When new designs are required priority:medium and removed design required When new designs are required labels Oct 27, 2021
@sendra
Copy link
Contributor

sendra commented Nov 11, 2021

This is happens for network native tokens when the deposit/withdraw goes through WethGateway contract, so the msg.sender is the wethgateway instead of the user, and this is why it doesn't show the deposits and withdraws with native token and only the change of colateral

@foodaka
Copy link
Contributor Author

foodaka commented Dec 3, 2021

@sendra ok i get it now, should we just close this out for now then? I think this is also related to #204

@sakulstra
Copy link
Contributor

sakulstra commented Dec 3, 2021

No let's keep it open, it's a bit related as in "if the user would deposit weth directly it would show up here", but it's mostly a bug on thegraph where the weth-gateway would need special handling as even after #204 is implemented, eth despoists won't show up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants