Replies: 3 comments
-
I strongly agree with 1. |
Beta Was this translation helpful? Give feedback.
-
1 sounds good to me. On a different FOSS project facing this challenge, we ended up going with user-specification rather than trying to pick up via locale or language. If there's an opportunity to address other formatting pain points like #16954, #16610, #7470 during this process - or at least pave the way for the future - that would be swell. |
Beta Was this translation helpful? Give feedback.
-
I believe this was implemented in #20075 which appeared in Superset version 3.0.0. People following this discussion should see that pull request discussion for examples of how to implement this in their deployment of Superset. |
Beta Was this translation helpful? Give feedback.
-
Problem
Superset currently uses
d3-format
default settings for international number formatting. I.e. every number that is getting formatted with one of thed3-format
options in Superset, uses the English US (en-US
in BCP47 notation) settings for:This prevents the greater adoption of Superset by users who have different expectations for number formatting.
The main problem exists for users in regions who use the exact opposite configuration of the decimal point and the group separator, i.e. all German speaking regions use
.
as the group separator and,
as the decimal point, which will cause confusion for those user groups in the current configuration.Solutions
There is one open PR that attempted one possible solution. #20075
That PR made 2 major design decisions, which should be reviewed before implementing such feature. These 2 design decisions are:
de
,de-AU
,de-CH
orde-DE
in your case) in favor of manually creating custom D3 number formatting rules via a newD3_FORMAT
Flask configuration property.What are everyone's thoughts about the above 2 decisions?
(I am assuming that the overall feature of changing international number formatting options in general is something that we can all agree on is needed 😁)
Beta Was this translation helpful? Give feedback.
All reactions