Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit check for sum vs integral in line flux + moments #1142

Open
rosteen opened this issue May 28, 2024 · 0 comments
Open

Add unit check for sum vs integral in line flux + moments #1142

rosteen opened this issue May 28, 2024 · 0 comments
Labels
analysis Spectral analysis/measurement tools enhancement

Comments

@rosteen
Copy link
Contributor

rosteen commented May 28, 2024

Currently, line flux does an integral (well, a sum multiplying by dx, see #712 for more discussion), whereas the moment calculations are doing simple sums. I'm fixing the moment calculations to match line flux in #1141, but really for both of these we should have a check to do the simple sum in the appropriate case of flux units that are actually flux (e.g. W/m2) rather than the usual case of flux density (e.g. Jy) that requires the integral.

@rosteen rosteen added enhancement analysis Spectral analysis/measurement tools labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Spectral analysis/measurement tools enhancement
Projects
None yet
Development

No branches or pull requests

1 participant