Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google font stylesheet element is html encoded #4

Open
olizilla opened this issue Feb 12, 2018 · 2 comments
Open

Google font stylesheet element is html encoded #4

olizilla opened this issue Feb 12, 2018 · 2 comments
Labels

Comments

@olizilla
Copy link

In ISO I'm hitting the export to HTML button, and seeing stylesheet element for the googlefont showing up in the rendered output.

screen shot 2018-02-12 at 09 16 38

In the source, I see it's getting html encoded.

meta name="generator" content="Compositor Iso"/><link rel='stylesheet' href='https://fonts.googleapis.com/css?family=PT+Serif'>

Everything else is fine, just that element.

This is on [email protected] and [email protected]

@johno johno added the bug label Feb 12, 2018
@jxnblk
Copy link
Member

jxnblk commented Feb 13, 2018

Thanks! It looks like Iso might not be recognizing the tag without the closing /> for JSX. Can you try adding the closing part to see if that works? I'm not sure how to reproduce this, but could you share a code snippet from the .jsx file if that doesn't work?

@olizilla
Copy link
Author

The project is using both iso and lab; the google font link is being added by some automagic, I've not included a link to it in my iso codes.

Of note, I used the font stack select in lab to select PT Serif, so my theme.json has this for the fonts property

{
  "fonts": [
    "\"PT Serif\", serif"
  ],
/* and the rest */
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants