Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore package name in AndroidManifest.xml #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nightohl
Copy link

@nightohl nightohl commented Jun 28, 2024

Summary

the package name has removed in AndroidManifest.xml file.
It's causing an error when users who using this library in their project operate pod install command.

I checked the history of the file, and it seems like an unintended petty mistake.
so I just rolled back the package name in the xml file.

I explained detail in the issue, so please check it out.
thanks!

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@MrRefactor MrRefactor self-requested a review June 29, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cause pod install error (No package name found)
3 participants