feat: print jornalctl log before failure of WaitForLogMessage #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(deps): update dependency go to v1.22.1
…retchr-testify-1.x fix(deps): update module github.com/stretchr/testify to v1.9.0
…l#24) refact: export env variables to show up in documentation on pkg.go.dev
farshidtz
reviewed
Apr 29, 2024
utils/config.go
Outdated
| t.Fatalf("Time out: reached max %d retries.", maxRetry) | ||
| t.Logf("Time out: reached max %d retries.", maxRetry) | ||
| stdout, _, _ := Exec(t, | ||
| fmt.Sprintf("sudo journalctl --lines=10 --no-pager --unit=snap.\"%s\".otbr-agent --priority=notice", snap)) |
There was a problem hiding this comment.
This will query the logs of a particular app (otbr-agent) and makes assumptions on the priority level and required number of lines to have sufficient debugging information.
The function could make use of a refactored SnapLogs function, rather than writing a new command.
Signed-off-by: Lincoln Wallace <[email protected]>
locnnil
force-pushed
the
improve-waitforlog
branch
from
f76b0de
to
d04c48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitForLogMessageto print the tail before failing #28