CliToolUpdate & CliToolInstaller are not using the result of selectVersion

[axel7083]

Is your enhancement related to a problem? Please describe

While working on containers/podman-desktop-extension-minikube#149 I found some weird behaviour.

Here is the interface for the CliToolInstaller from the extension api.

podman-desktop/packages/extension-api/src/extension-api.d.ts

Lines 4536 to 4540 in bca0cdc

	export interface CliToolInstaller {
	selectVersion: () => Promise<string>;
	doInstall: (logger: Logger) => Promise<void>;
	doUninstall: (logger: Logger) => Promise<void>;
	}

Here is the workflow we currently have

1. extension register CliToolInstaller
2. User go to CLI Page and click on install
3. Core call selectVersion (do nothing with the result ??)
4. Core call doInstall

The doInstall should take as argument the version got from selectVersion, currently this is not the case, and this is how extension are doing:

  let releaseToInstall: KindGithubReleaseArtifactMetadata | undefined;

 let releaseToInstall: KindGithubReleaseArtifactMetadata | undefined;
  let releaseVersionToInstall: string | undefined;
  kindCli.registerInstaller({
    selectVersion: async () => {
      const selected = await installer.promptUserForVersion();
      releaseToInstall = selected;
      return releaseVersionToInstall; // /!\ useless 
    },
    doInstall: async _logger => {
      if (!releaseToInstall) {
        throw new Error(`Cannot install ${KIND_CLI_NAME}. No release selected.`);
      }

     // install releaseToInstall

      releaseToInstall = undefined;
    },
    doUninstall: async _logger => {
      ...
    },
  });

The extension declare a scoped variable that is shared between the selectVersion and doInstall function. It increase a lot the complexity.

What happen to the return value of selectVersion

It get lost

1. The frontend request SelectVersion

podman-desktop/packages/renderer/src/lib/preferences/PreferencesCliTool.svelte

Line 45 in 9e77a7f

newVersion = await window.selectCliToolVersionToUpdate(cliTool.id);

2. The CliToolRegistry ask the extension the value, and pass it down to the frontend

podman-desktop/packages/main/src/plugin/cli-tool-registry.ts

Line 98 in 31f6a23

async selectCliToolVersionToUpdate(id: string): Promise<string> {

3. The frontend send it back to the core

podman-desktop/packages/renderer/src/lib/preferences/PreferencesCliTool.svelte

Line 58 in 9e77a7f

await window.updateCliTool(cliTool.id, loggerHandlerKey, newVersion, eventCollect);

4. The core use it to create a task Updating kind to X.Y.Z

podman-desktop/packages/main/src/plugin/index.ts

Line 1405 in e312a4d

title: `Update ${tool.name} to v${version}`,

And that's where it stop.

Describe the solution you'd like

Solution proposal would be backward compatible

The CliToolInstaller should be changed to

  export interface CliToolInstaller {
    selectVersion: () => Promise<string>;
-   doInstall: (logger: Logger) => Promise<void>;
+   doInstall: (logger: Logger, version: string) => Promise<void>;
    doUninstall: (logger: Logger) => Promise<void>;
  }

And that's all :)

abvousily this should also to CliToolUpdate

  export interface CliToolSelectUpdate {
    selectVersion: () => Promise<string>;
-   doUpdate: (logger: Logger) => Promise<void>;
+   doUpdate: (logger: Logger,  version: string) => Promise<void>;
  }

Describe alternatives you've considered

No response

Additional context

No response