Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: treats body with URL as footer #4101

Open
1 of 4 tasks
abitrolly opened this issue Jul 20, 2024 · 2 comments
Open
1 of 4 tasks

bug: treats body with URL as footer #4101

abitrolly opened this issue Jul 20, 2024 · 2 comments
Labels

Comments

@abitrolly
Copy link
Contributor

abitrolly commented Jul 20, 2024

Steps to Reproduce

1. Add this commit message:

fix: ingest - do not double strip /doc/ prefix

It is already stripped here
https://gitlab.com/gitlab-community/modelops/applied-ml/code-suggestions/ai-assist/-/blob/22bb9cf2b996dc2ec347bad761abb12fd11bcf75/scripts/ingest/gitlab-docs/steps/parse.rb#L16
  1. Watch commitlint failure for footer

Current Behavior

⧗   input: fix: ingest - do not double strip /doc/ prefix
It is already stripped here
https://gitlab.com/gitlab-community/modelops/applied-ml/code-suggestions/ai-assist/-/blob/22bb9cf2b996dc2ec347bad761abb12fd11bcf75/scripts/ingest/gitlab-docs/steps/parse.rb#L16
✖   footer's lines must not be longer than 100 characters [footer-max-line-length]
⚠   footer must have leading blank line [footer-leading-blank]
✖   found 1 problems, 1 warnings

Expected Behavior

⧗   --- input ---
fix: ingest - do not double strip /doc/ prefix

It is already stripped here
https://gitlab.com/gitlab-community/modelops/applied-ml/code-suggestions/ai-assist/-/blob/22bb9cf2b996dc2ec347bad761abb12fd11bcf75/scripts/ingest/gitlab-docs/steps/parse.rb#L16
✖   body's lines must not be longer than 100 characters [body-max-line-length]
✖   found 1 warnings

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

Add the example to tests that cover bugs to be fixed.

Fix parser to return these lines in body.

Context

https://gitlab.com/gitlab-community/modelops/applied-ml/code-suggestions/ai-assist/-/jobs/7372910347

commitlint --version

i don't know

git --version

i don't know

node --version

i don't know

@escapedcat
Copy link
Member

Does this duplicate or relate to #4099, #3695, #3129?

@abitrolly
Copy link
Contributor Author

@escapedcat no. This one is about URL. Other issues have different inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants