Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add variant="inside" for DBDrawer #3262

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add variant="inside" for DBDrawer #3262

wants to merge 3 commits into from

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Sep 30, 2024

Proposed changes

closes #3258

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) September 30, 2024 13:21
@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-drawer-non-modal

@mfranzke mfranzke added this to the v0.5.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Allow opening DBDrawer with show besides of backdrop prop
2 participants
@nmerget @mfranzke