Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default slots not rendered due to vue version conflict #3299

Open
1 of 7 tasks
schneisn opened this issue Oct 9, 2024 · 1 comment · May be fixed by #3318
Open
1 of 7 tasks

Default slots not rendered due to vue version conflict #3299

schneisn opened this issue Oct 9, 2024 · 1 comment · May be fixed by #3318
Assignees
Labels
🐛bug Something isn't working 👩‍👧‍👦community feedback Feedback from community
Milestone

Comments

@schneisn
Copy link

schneisn commented Oct 9, 2024

Which generators are impacted?

  • All
  • HTML
  • React
  • Angular
  • Vue
  • Web components
  • Power Apps

Reproduction case

Our project has a dependency to vue version 3.5.8. Mono has a dependency to vue version 3.5.11.

The conflicting vue versions resulted in default slots not being rendered and the error
TypeError: Cannot read properties of null (reading 'ce') at renderSlot

The same issue is described here: https://stackoverflow.com/questions/72036673/typeerror-cannot-read-properties-of-null-reading-isce-custom-component-li

A possible solution could be to externalize the vue dependency in mono to prevent shipping it and having the vue dependency twice in a project.
See https://vite.dev/guide/build.html#library-mode

Expected Behaviour

No error occurs.

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response

@mfranzke mfranzke added 🐛bug Something isn't working 👩‍👧‍👦community feedback Feedback from community labels Oct 9, 2024
@mfranzke
Copy link
Member

mfranzke commented Oct 9, 2024

we'll investigate whether this dependency could actually get moved to be a devDependency.

@mfranzke mfranzke modified the milestones: Guidelines 3.0 RC, v0.5.0 Oct 9, 2024
@mfranzke mfranzke linked a pull request Oct 16, 2024 that will close this issue
5 tasks
@mfranzke mfranzke linked a pull request Oct 16, 2024 that will close this issue
5 tasks
@mfranzke mfranzke self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 👩‍👧‍👦community feedback Feedback from community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants