Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust brush if domain changes in ordinal brushing #1814

Open
gordonwoodhull opened this issue Feb 15, 2021 · 0 comments
Open

adjust brush if domain changes in ordinal brushing #1814

gordonwoodhull opened this issue Feb 15, 2021 · 0 comments

Comments

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Feb 15, 2021

#1809 got me thinking in depth about ordinal brushing.

If the order of the ordinal keys do not change, but keys are added or removed due to remove_empty_groups or data streaming, it's possible to change the brush to fit the data.

Since you don't want a redraw to trigger a refilter, this can only work if the dimension uses the natural order of the key, and we use dimension.filterRange (no filterHandler) on the ordinal domain.

That would be a nice simplification. I wonder if I considered this and rejected it when writing the original example.

@gordonwoodhull gordonwoodhull changed the title rebrush if domain changes in ordinal brushing adjust brush if domain changes in ordinal brushing Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant