Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader should not cache bytes when they don't start with wasm magic number #138

Open
dsherret opened this issue Apr 23, 2024 · 0 comments
Open

Loader should not cache bytes when they don't start with wasm magic number #138

dsherret opened this issue Apr 23, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dsherret
Copy link
Member

dsherret commented Apr 23, 2024 •
edited
Loading

The code in https://github.com/denoland/wasmbuild/blob/main/lib/loader.ts should be updated to not cache a wasm module if it doesn't start with the wasm magic number (\0asm)

denoland/deno_graph#453
@dsherret dsherret mentioned this issue Apr 23, 2024
Closed
@dsherret dsherret added enhancement New feature or request good first issue Good for newcomers labels Apr 23, 2024
@dsherret dsherret changed the title Loader should check for wasm magic number Loader should not cache bytes when they don't start with wasm magic number Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsherret