Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a command line application package to replace cobra #117

Open
4 tasks
at15 opened this issue May 18, 2019 · 2 comments
Open
4 tasks

Create a command line application package to replace cobra #117

at15 opened this issue May 18, 2019 · 2 comments
Assignees
@at15
Labels
phase/proposal someone has an idea, no one has taken it size/L large issue/PR type/new-package
Milestone
0.0.14

Comments

@at15
Copy link
Member

at15 commented May 18, 2019

Cobra is a package from building cli, its recent release 0.0.4 introduced viper as its dependency and dragged in etcd due to its remote config, so it's time to move away from cobra (can still use spf13/pflags). This makes gommon more self contained (and allow us to reinvent another wheel)

TODO

  • chose a package name cc @arrowrowe @gaocegege
  • check if I can put a go.mod for cmd/gommon and void the top level go.mod to have spf13/cobra
  • required features
    • more flexible command definition, i.e. allow using interface instead of its own struct
    • interactive repl
  • survey

Ref
@at15 at15 added the size/L large issue/PR label May 18, 2019
@at15 at15 self-assigned this May 18, 2019
@at15 at15 added phase/proposal someone has an idea, no one has taken it type/new-package labels May 18, 2019
@at15
Copy link
Member Author

at15 commented Jan 1, 2020

btw: @arrowrowe any idea for the name (我要开坑了 严肃脸

@at15
Copy link
Member Author

at15 commented Jan 19, 2020

will just call it dcli for now

at15 added a commit to dyweb/go.ice that referenced this issue Jan 19, 2020
@at15
[cli] Copy back old cli package using cobra
94dcca8 
- So that code depend on it could compile
- xephonhq/xephon-k#71
- In the long term, will switch to gommon/dcli dyweb/gommon#117
@at15 at15 mentioned this issue Jan 19, 2020
Merged
at15 added a commit that referenced this issue Feb 22, 2020
@at15
[mod] Add go.mod for cmd/gommon to reduce dependencies
c5a6950 
- Using gommon does not require spf13/cobra, but before #117 we will
stick with cobra for the time being.
- spf13/cobra imports spf13/viper and drags in etcd spf13/viper#679
@at15 at15 added this to the 0.0.14 milestone Jun 29, 2020
@at15 at15 mentioned this issue Jun 29, 2020
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@at15 at15

Labels
phase/proposal someone has an idea, no one has taken it size/L large issue/PR type/new-package
Projects
None yet
Milestone
0.0.14
Development

No branches or pull requests
1 participant
@at15