Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line_break in theme.ron is interpreted incorrectly #2312

Open
savchenko opened this issue Jul 27, 2024 · 2 comments
Open

line_break in theme.ron is interpreted incorrectly #2312

savchenko opened this issue Jul 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@savchenko
Copy link

savchenko commented Jul 27, 2024

Describe the bug
Line-breaks colour is rendered verbatim, as the HEX colour.

To Reproduce
Add the following to your theme.ron

( 
  line_break: Some("#005e8b")
)

Expected behavior
Hunks in gitui are exactly the same as in the git diff and files on disk.

Screenshots
image

image

Context (please complete the following information):

  • OS/Distro + Version: Debian 12
  • GitUI Version: nightly 2024-06-28 (95e1d4d) as well as the release build from 4ef633a
  • Rust version: rustc 1.76.0 (07dca489a 2024-02-04)

Additional context
The 005e8b string is not a git commit hash, e.g. git show 005e8b returns nil.

@savchenko savchenko added the bug Something isn't working label Jul 27, 2024
@savchenko savchenko changed the title Stray text rendered in new hunks Stray text rendered in modified hunks Jul 27, 2024
@savchenko savchenko changed the title Stray text rendered in modified hunks line_break in theme.ron is interpreted incorrectly Aug 9, 2024
@wugeer
Copy link
Contributor

wugeer commented Sep 3, 2024

@savchenko The line_break parameter is set to a string character, not a color.

image

@extrawurst
Copy link
Owner

yeah its a hack. that should be cleaned up at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants