Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Metrics don´t wait for benchmarks to end making the bechmark fail #354

Open
2 tasks done
RomainLanz opened this issue Oct 18, 2024 · 0 comments
Open
2 tasks done

Node Metrics don´t wait for benchmarks to end making the bechmark fail #354

RomainLanz opened this issue Oct 18, 2024 · 0 comments

Comments

@RomainLanz
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

Hey there! 👋🏻

It seems that the Node Metrics action commit make the benchmark break because it cannot commit the results: https://github.com/fastify/benchmarks/actions/runs/11408562549/job/31747004872
@RomainLanz RomainLanz changed the title Node Metrics run before benchmarks making the bechmark fail Node Metrics don´t wait for benchmarks to end making the bechmark fail Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RomainLanz