Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB14887376: AppStore.requestReview(in:) is not a complete alternative to the deprecated SKStoreReviewController.requestReview() #544

Open
sindresorhus opened this issue Aug 22, 2024 · 1 comment

Comments

@sindresorhus
Copy link
Member

  • Date: 2024-08-22
  • Resolution: Open
  • Area: StoreKit
  • OS: macOS 14.5
  • Type: Incorrect/Unexpected Behavior

Description

SKStoreReviewController.requestReview() is deprecated in favor of AppStore.requestReview(in:). The problem is that AppStore.requestReview(in:) requires passing in a NSViewController, and in some contexts, this is not possible. For example, a menu bar app that only has a NSMenu when you click it. It has no NSViewController that could be passed in. I suggest making the controller parameter optional.

@ukushu
Copy link

ukushu commented Sep 27, 2024

Also part of manual request review stoped work in macOS 15.

It is alternative, but it DOES NOT WORK even if it is not marked as deprecated functionality.

image

All that this link do now is shows product page. Without product review sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants