Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing pass #744

Open
db091756 opened this issue Aug 22, 2024 · 0 comments
Open

Typing pass #744

db091756 opened this issue Aug 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@db091756
Copy link
Member

What's the new feature?

Do a typing pass of the repo to ensure as many of the PyRight complaint are fixed as possible:

  1. Look into typing.overload
  2. Use jax.typing in as much as the codebase as possible to check array shapes

What value does this add?

Consistency, better user experience

Is there an alternative you've considered?

No response

Additional context

No response
@db091756 db091756 added enhancement New feature or request new Something yet to be discussed by development team labels Aug 22, 2024
@db091756 db091756 self-assigned this Aug 22, 2024
@db091756 db091756 removed the new Something yet to be discussed by development team label Aug 22, 2024
@db091756 db091756 linked a pull request Aug 22, 2024 that will close this issue
Feat/jaxtyping #746
Merged
9 tasks
@db091756 db091756 removed a link to a pull request Sep 4, 2024
Feat/jaxtyping #746
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@db091756