Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @var instead of @property #97

Open
mkrauser opened this issue Sep 18, 2019 · 2 comments
Open

Use @var instead of @property #97

mkrauser opened this issue Sep 18, 2019 · 2 comments
Labels

Comments

@mkrauser
Copy link
Contributor

In the generated classes, the properties have a docblock like this attached:

/**
 * @property string $addressStreet
 */
private $addressStreet = null;

According to the phpdocumentor-Docs @Property is meant to be used for magic properties.
For declared class properties @var is correct.

If Symfony Serializer is used for such data-structures, this becomes more important, since the doc-blocks are used by the serializer to determine the correct types.

@goetas goetas added the bug label Sep 18, 2019
@goetas
Copy link
Member

goetas commented Sep 18, 2019

That's true. PR with a fix is welcome!

@RafaelKr
Copy link

This can be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants