Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize custom theme module contract #69

Open
BRKalow opened this issue Mar 21, 2023 · 0 comments
Open

Finalize custom theme module contract #69

BRKalow opened this issue Mar 21, 2023 · 0 comments

Comments

@BRKalow
Copy link
Contributor

BRKalow commented Mar 21, 2023

Currently, themes are expected to expose a default export and a named Page export. The default export is the Layout, and the named export is used as the page component for the dynamic swingset route. It might make more sense to have both of these be named exports for clarity.

// layout.ts
import { layout } from 'swingset/theme'

export default layout
// page.ts
import { page } from 'swingset/theme'

export default page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant