Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open PWA directly in browser language #1490

Open
ximfritz opened this issue Aug 23, 2023 · 7 comments
Open

Open PWA directly in browser language #1490

ximfritz opened this issue Aug 23, 2023 · 7 comments
Labels
enhancement Enhancement to an existing feature

Comments

@ximfritz
Copy link

ximfritz commented Aug 23, 2023

Is your feature request related to a problem? If yes, please describe it.

If the PWA has multiple languages the PWA should on the first visit open the PWA in the browser language if this language is available.

I am always frustrated when i use my english browser and the pwa open up with the language de. Although the PWA has two languages de and en.

Describe the desired solution.

The PWA redirects the website on the first load to the browser specific language.

1- Start my browser who uses the english language
2 - Type in url
3 - Press enter
4 - The shop uses the english language

Describe alternatives you've considered.

Provide additional context.
If you have a shop with 10 languages where you have customers from all over the world it is annoying for each customer to switch the language on the first visit.

AB#88822

@ximfritz ximfritz added the enhancement Enhancement to an existing feature label Aug 23, 2023
@shauke
Copy link
Collaborator

shauke commented Aug 23, 2023

We will discuss this, but there was already a pull request for this that was not merged since we did not actually wanted this functionality. See #583

@SGrueber
Copy link
Collaborator

Maybe PR #1447 would solve this problem

@ximfritz
Copy link
Author

ximfritz commented Aug 29, 2023

@SGrueber Do you mean this would solve this feature, or which problem do you mean?

@SGrueber
Copy link
Collaborator

@ximfritz You wrote: I am always frustrated when i use my english browser and the pwa open up with the language de. Although the PWA has two languages de and en.

And I guessed to save your language selection in a cookie would solve this problem.

@ximfritz
Copy link
Author

@SGrueber You mean when I save the browser language at the app start in the cookie it would solve this problem. Do I atomatically get than an redirect to the correct language?

@SGrueber
Copy link
Collaborator

@ximfritz Yes, there is a redirect to the correct language on pwa start - we will add a feature toggle for the 'save language as cookie' soon and afterwards we will merge this PR

@ximfritz
Copy link
Author

@SGrueber I think we're talking past each other, I think i was not very clear.
The user visit the shop for the first time and never accept any cookies or did a language switch. The browser language is de, the PWA application has multiple languages and normally starts with the language en.

But instead of starting with en it starts with de, because of the browser language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants