Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regenerate proto #270

Open
isaackogan opened this issue Oct 8, 2024 · 4 comments
Open

regenerate proto #270

isaackogan opened this issue Oct 8, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@isaackogan
Copy link
Owner

regenerate proto definitions to add support for #269
@isaackogan
Copy link
Owner Author

if someone does this and PRs that would be great i can't do it before the 20th

@isaackogan isaackogan added the enhancement New feature or request label Oct 8, 2024
@steampoweredtaco
Copy link
Contributor

steampoweredtaco commented Oct 9, 2024 •
edited
Loading

I looked into this and it uses dynamic loading of the .proto file directly in webcastProtobuf.js; so... I think #269 just works? Neat.
Edit: I'm dumb.

@isaackogan
Copy link
Owner Author

I looked into this and it uses dynamic loading of the .proto file directly in webcastProtobuf.js; so... I think #269 just works? Neat.

Unfortunately, this is not JS

@steampoweredtaco
Copy link
Contributor

My bad, the PR referenced TikTok live connector and I pulled that repo instead, hahah. Opps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaackogan @steampoweredtaco