Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeSelector在模板里如果给了默认值,那么即使在部署时修改了,在负载的yaml中还是会存在 #4170

Open
WYmindsky opened this issue Jul 25, 2023 · 1 comment
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/medium sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@WYmindsky
Copy link

Describe the bug
nodeSelector在模板里如果给了默认值,那么即使在部署时修改了,在负载的yaml中还是会存在

For UI issues please also add a screenshot that shows the issue.

Versions used(KubeSphere/Kubernetes)
KubeSphere: v3.2.1
Kubernetes: 1.21

Environment
How many nodes and their hardware configuration:
3 masters: 8cpu/16g

To Reproduce
Steps to reproduce the behavior:

  1. 在模板里设置nodeSelector默认值
    nodeSelector:
    label1: "true"
    label2: "true"
  2. 上传到应用模板,并部署应用
  3. 在填写values.yaml配置时,修改nodeSelector的值,删掉默认值,改为label3: "true"
  4. 查看部署的负载yaml,能够看到nodeSelector中有三个选择器:label1,label2,label3

Expected behavior
nodeSelector应该以我更新的为最新值,替换掉默认值

Existed merge
这个merge看样是通过put而不是patch方法解决的,但在v3.2.1上还是存在,没合入?
https://github.com/kubesphere/console/pull/661/files

@WYmindsky WYmindsky added the kind/bug Categorizes issue or PR as related to a bug. label Jul 25, 2023
@VioZhang VioZhang added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Oct 13, 2023
@harrisonliu5 harrisonliu5 self-assigned this Oct 17, 2023
@redscholar
Copy link
Contributor

We haven't been able to reproduce your issue on our end. It seems like you're deploying it using your custom application. The possible reason could be that the values configured in your Helm template are incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/medium sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Development

No branches or pull requests

5 participants