Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in diff when providing comps #164

Open
mathtimm opened this issue Jan 31, 2024 · 0 comments
Open

Bug in diff when providing comps #164

mathtimm opened this issue Jan 31, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mathtimm
Copy link
Collaborator

mathtimm commented Jan 31, 2024

When providing an array of comparison stars with the shape (aperture, star), a Type error appears.

This is fixed by changing line 326 by:
weights = np.zeros(self.fluxes.shape[0:-1])

I'll make a pull request with the fix and a test as well to make sure it works fine!

image (1)

@mathtimm mathtimm added the bug Something isn't working label Jan 31, 2024
mathtimm added a commit to mathtimm/prose3_mt that referenced this issue Jan 31, 2024
@lgrcia lgrcia closed this as completed Feb 6, 2024
@lgrcia lgrcia reopened this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants