-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tooltips on disabled buttons are not rendered #476
Comments
@danielrona Personally, I prefer that a disabled button not provide any feedback/interaction (such as displaying a tooltip) as that could confuse a user into thinking it is active. |
@jeffchown I prefer to inform users what they have to toggle/switch/or fill out specifc things this lets me free up some space in the UI and not have random error messages that might be on a different tab / section of the page. I guess this is a very subjective topic, should have opened a discussion rather than a issue. |
@danielrona Agreed, there are different ways to approach this. You can 'force' the tooltip this way:
|
Hmmm this is tricky. A brief search has shown me there isn't really a consensus whether or not tooltips should be shown on disabled buttons. Seeing that are actually plenty of valid reasons to use them on disabled buttons tells me we should at least support the option. The tricky bit is that in Flux our buttons have Turns out this isn't just an odd quirk of Flux, but also how Bootstrap works and they even documented the workaround!:
I wonder if maybe we just do the same thing. Have a section on the tooltips page or button page about showing on disabled tooltips just like Bootstrap does. What do we think? |
Given your explanation @calebporzio, I think documenting the reason and workaround is good for now until/if enough use cases arise to add the option. |
While tying to explain to users why a button is disabled I realized that tooltips do not show up on disabled buttons.
The text was updated successfully, but these errors were encountered: