Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework color variants in order to reduce file size #993

Open
samanpwbb opened this issue Apr 13, 2021 · 1 comment
Open

Rework color variants in order to reduce file size #993

samanpwbb opened this issue Apr 13, 2021 · 1 comment

Comments

@samanpwbb
Copy link
Contributor

samanpwbb commented Apr 13, 2021

Our best bet for cutting down on Assembly's built file size is to rework the color variant build process. We generate a lot of CSS in order to support multi-color forms. Most apps only need one checkbox color, but often apps will want a few different button colors. Can the color variant API be adjusted so user may declare which form elements they'd like to color which colors?

@thefifthisa thefifthisa added the p2 label Apr 13, 2021
@samanpwbb samanpwbb assigned samanpwbb and unassigned samanpwbb Apr 26, 2021
@samanpwbb
Copy link
Contributor Author

The option to do this already exists, we just haven't set it up (see https://github.com/mapbox/assembly#colorvariants-option).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants