Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnConnectionChanged parameter type differs from ADS version #88

Open
Charles-Gagnon opened this issue Jul 6, 2023 · 1 comment
Open

OnConnectionChanged parameter type differs from ADS version #88

Charles-Gagnon opened this issue Jul 6, 2023 · 1 comment

Comments

@Charles-Gagnon
Copy link
Contributor

Here we defined the parameter for onConnectionChanged to have an "ownerUri" property, but the corresponding type in ADS of ChangedConnectionInfo has connectionUri.

Since extensions are typically only going to be using the azdata typings this shouldn't be the case, and could easily lead to providers sending the wrong values.
@Charles-Gagnon
Copy link
Contributor Author

Changes here should be carefully verified though, one such attempt already broke some key functionality - see microsoft/azuredatastudio#23565 for more details

@Charles-Gagnon Charles-Gagnon mentioned this issue Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Charles-Gagnon