Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Communique Issues menu #187

Open
imcbride opened this issue Jan 22, 2020 · 7 comments
Open

Update Communique Issues menu #187

imcbride opened this issue Jan 22, 2020 · 7 comments
Assignees

Comments

@imcbride
Copy link
Member

https://www.middlebury.edu/institute/communique

On this site we would like to change the first menu in the right nav to have a header labelled "Issues", clicking on which expands or contracts the list of menu items. The menu should begin in a collapsed state.

Stylistically, it can appear like other menus such as the one on the IEM site with "Issues" in place of "International Education Management" and the list of issues appearing indented below.

What, if any, markup and style changes do we need to make to support this?

@zebapy
Copy link
Contributor

zebapy commented Jan 22, 2020

Would "Issues" have a page to navigate to or only be a button label?

@imcbride
Copy link
Member Author

Right now there's no such page for it. We could make one, but a button label would work fine.

@zebapy
Copy link
Contributor

zebapy commented Jan 22, 2020

Can we render the issues menu in another page-nav but above the other page-nav? Then we can add 1 modifier class to that issues page-nav to always show the mobile toggle button and use all the same markup.

Screenshot 2020-01-22 09 42 27

The result would be

<div class="page-nav">
  <button>issues</button>
  <nav><ul>ISSUES MENU</ul></nav>
</div>

<div class="page-nav">
other menu
</div>

@imcbride
Copy link
Member Author

Right now they're in the same <div class="page-nav"> so that the Additional Navigation toggler for mobile controls both. If we split them up would we need additional mobile togglers?

@zebapy zebapy transferred this issue from middlebury/midd-frontend Jan 22, 2020
@imcbride
Copy link
Member Author

I've fixed the bug that prevented the theme debugging from working on newsrooms so this is easier to see where the template breaks are.

view-source:http://saw.middlebury.edu/~imcbride/institute/communique

Thanks for moving the issue to the right project.

@imcbride imcbride changed the title Allow for accordion menus Update Communique Issues menu Jan 23, 2020
@imcbride
Copy link
Member Author

Is there a class I can apply to a wrapper element or the <h2> so that the gray bar appears above the menu title?

Screen Shot 2020-01-23 at 9 47 32 AM

@zebapy
Copy link
Contributor

zebapy commented Jan 23, 2020

@imcbride I've added our suggested styles for these elements a70b04f

Note the page-nav__label class on the h2 and the page-nav__link--cta for the view all link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants