Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clear indication of why resize-swap fails #958

Open
Omrigan opened this issue Jun 10, 2024 · 1 comment
Open

Add a clear indication of why resize-swap fails #958

Omrigan opened this issue Jun 10, 2024 · 1 comment
Labels
c/autoscaling/neonvm Component: autoscaling: NeonVM

Comments

@Omrigan
Copy link
Contributor

Omrigan commented Jun 10, 2024

Problem description / Motivation

#887 introduced the ability to resize swap after the VM has already started. This mechanism is meant to be used upon endpoint binding. Upon resizing, the /neonvm/bin/resize-swap is deleted from the VM, to prevent attempts to resize the swap mid-execution. The way it can currently happen is e.g. compute_ctl restarts.

The reason why resizing swap is not allowed after postgres has started is that resizing assumes swapoff, and then swapon. swapoff in the presence of customer workload may lead to OOMs, so is is not allowed.

However, the way this protection is implemented - by removing the implementation script confuses people, and overall changing a set of scripts mid-execution isn't a good idea.

Feature idea(s) / DoD

The error message upon resizing mid-execution should be clear. We might want to have a way to do the resize forcefully.

Implementation ideas

Probably this functionality will be re-implemented as a part of neonvmd, so no more scripts.

@Omrigan Omrigan added the m/good_first_issue Moment: when doing your first Neon contributions label Aug 6, 2024
@petuhovskiy petuhovskiy self-assigned this Aug 6, 2024
@stradig
Copy link
Contributor

stradig commented Oct 8, 2024

Decision: We will wait for neonvm-daemon to become and thing and then tackle it.

@stradig stradig removed the m/good_first_issue Moment: when doing your first Neon contributions label Oct 8, 2024
@sharnoff sharnoff added the c/autoscaling/neonvm Component: autoscaling: NeonVM label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/autoscaling/neonvm Component: autoscaling: NeonVM
Projects
None yet
Development

No branches or pull requests

4 participants