Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a default DisconnectHandler which closes the session on non-retryable errors #188

Open
jrobsonchase opened this issue Sep 6, 2024 · 0 comments
Open

Provide a default DisconnectHandler which closes the session on non-retryable errors #188

jrobsonchase opened this issue Sep 6, 2024 · 0 comments

Comments

@jrobsonchase
Copy link
Collaborator

See #176

Our default always-retry-everything behavior is confusing. If we had a default disconnect handler which closed the session on non-retryable authentication errors, ngrok.Connect would exit with an error as most users would expect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrobsonchase