Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for UV_EINVAL on C++ API #172

Open
RafaelGSS opened this issue Aug 23, 2024 · 2 comments
Open

Add test for UV_EINVAL on C++ API #172

RafaelGSS opened this issue Aug 23, 2024 · 2 comments
Assignees

Comments

@RafaelGSS
Copy link
Member

"Another task to do could be adding a test that actually checks the UV_EINVAL by exercising the C++ API, as with the change you just proposed, the JS API will behave differently" - @santigimeno

@RafaelGSS RafaelGSS self-assigned this Aug 23, 2024
@RafaelGSS
Copy link
Member Author

As I said in #173 (comment). It might require creating a proper cctest setup for SharedEnvInst and so on, right?

@santigimeno
Copy link
Member

Easier to implement it as an addon. Take a look or modify https://github.com/nodesource/nsolid/blob/node-v20.x-nsolid-v5.x/test/addons/nsolid-heap-sampler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants