Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint-commit-message failing on unexpected namespace #175

Open
RafaelGSS opened this issue Aug 27, 2024 · 0 comments
Open

lint-commit-message failing on unexpected namespace #175

RafaelGSS opened this issue Aug 27, 2024 · 0 comments

Comments

@RafaelGSS
Copy link
Member

I noticed we've been using agents as namespace (e.g 3913f0e). But, this is not valid as the namespace is validated against this set of rules https://github.com/nodejs/core-validate-commit/blob/5aa959cdd971d8426b4d7f48ea2ef95cdf4242d9/lib/rules/subsystem.js#L3.

So, if we want to enforce full green CI on PRs, we should either fork that repository and include our custom set of namespaces or just use generic ones, such as src or lib.

cc: @santigimeno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant