Can't add index on Topic.SystemName becase it's nvarchar(max) #7294

alinmircea · 2024-08-10T18:33:37Z

nopCommerce version: 4.60 +

Can't add index on Topic.SystemName becase it's nvarchar(max). Let's change it to nvarchar(400)

nopCommerce/src/Libraries/Nop.Data/Mapping/Builders/Topics/TopicTemplateBuilder.cs

Line 17 in 324486b

public override void MapEntity(CreateTableExpressionBuilder table)

Please add SystemName in column definition in the builder so column gets created with limited length.

Fixes nopSolutions#7294 Update `TopicTemplateBuilder.cs`, `Indexes.cs`, and `SchemaMigration.cs` to add an index on `Topic.SystemName` by changing its type to `nvarchar(400)`. * **TopicTemplateBuilder.cs** - Add `SystemName` column definition with `nvarchar(400)` in `MapEntity` method. * **Indexes.cs** - Add index creation for `Topic.SystemName` in `Up` method. * **SchemaMigration.cs** - Alter `SystemName` column to `nvarchar(400)` in `Up` method.

AndreiMaz assigned exileDev Aug 12, 2024

AndreiMaz added this to the Version 4.80 milestone Aug 12, 2024

AndreiMaz added the refactoring / source code label Aug 12, 2024

nirzaf linked a pull request Aug 13, 2024 that will close this issue

Fix topic index issue #7296

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can't add index on Topic.SystemName becase it's nvarchar(max) #7294

Can't add index on Topic.SystemName becase it's nvarchar(max) #7294

alinmircea commented Aug 10, 2024 •

edited by AndreiMaz

Loading

Can't add index on Topic.SystemName becase it's nvarchar(max) #7294

Can't add index on Topic.SystemName becase it's nvarchar(max) #7294

Comments

alinmircea commented Aug 10, 2024 • edited by AndreiMaz Loading

alinmircea commented Aug 10, 2024 •

edited by AndreiMaz

Loading