Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/lint: switch mega-linter with pre-commit & Ruff #617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Borda
Copy link

@Borda Borda commented Apr 28, 2024

Description

The pre-commit has already been in use, so lifting all linter to this single place makes the developer navigation much easier...
As passing over all used Liters, a few already deprecated them themselves in favor of Ruff, so merging all lining also to Ruff, which is all-in-one tool for lining and formatting

Related Issue

Closes #576

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

cc: @nvuillam

.bandit.yml Show resolved Hide resolved
.cspell.json Show resolved Hide resolved
@Borda
Copy link
Author

Borda commented Apr 28, 2024

@nvuillam could you pls install this bot - https://github.com/marketplace/pre-commit-ci

@Borda
Copy link
Author

Borda commented Jul 14, 2024

@nvuillam how is it going, would be great to see this PR landed... 🐰

@Borda
Copy link
Author

Borda commented Aug 14, 2024

@nvuillam how is it going, would be great to see this PR landed... 🐰

mind have a look, when you have time 🦩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace Megalinter with pre-commit bot
1 participant