Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab bar looks strange on Android (dark mode?) #40

Open
fredrikburmester opened this issue Oct 13, 2024 · 6 comments
Open

Tab bar looks strange on Android (dark mode?) #40

fredrikburmester opened this issue Oct 13, 2024 · 6 comments

Comments

@fredrikburmester
Copy link

Screenshot 2024-10-13 at 13 43 10

Code:

<NativeTabs.Screen
        name="(libraries)"
        options={{
          title: "Library",
          tabBarIcon: ({ color, focused, size }) =>
            require("@/assets/icons/server.rack.png"),
        }}
      />
@okwasniewski
Copy link
Owner

Hey, thanks for opening the issue.

This is indeed an issue with dark mode. The styles of the TabBar on Android are dictated by styles.xml file (Native project file).

We will probably need Expo Config plugin to allow for easy changes. Have you modified this file in any way? Also is the TabBar white if you switch to white mode?

@fredrikburmester
Copy link
Author

I have not modified the styles.xml at all. Would be great with an Expo config plugin.

I will test changing to light mode later today and report back.

@a-eid
Copy link

a-eid commented Oct 14, 2024

@okwasniewski there is no way to pass colors as props ?

@fredrikburmester
Copy link
Author

I found that changing color props did nothing. Have not had time to test light mode yet.

@okwasniewski
Copy link
Owner

@okwasniewski there is no way to pass colors as props ?

Not at the moment, this issue #11 is tracking the progress

@okwasniewski
Copy link
Owner

Issue tracking expo config plugin: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants